Re: [PATCH 11/13] target/i386: execute multiple REP/REPZ iterations without leaving TB

[Paolo Bonzini]

Il dom 15 dic 2024, 16:07 Richard Henderson <richard.henderson@linaro.org> ha scritto:

> @@ -1384,6 +1409,12 @@ static void do_gen_rep(DisasContext *s, MemOp ot,

>           gen_jcc_noeob(s, (JCC_Z << 1) | (nz ^ 1), done);
>       }
>   
> +    if (can_loop) {
> +        tcg_gen_subi_tl(cx_next, cpu_regs[R_ECX], 1);

Since we've just written back cx_next to ECX, this is the same as cx_next -= 1, yes?

Yeah, I wanted to make cx_next die at the assignment to ECX but it probably does not make a difference to generated code.

Paolo 

Anyway,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~