Re: [PATCH 10/20] hw/arm: Open-code pflash_cfi01_register()

[Bin Meng]

On Thu, Jan 5, 2023 at 6:43 AM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> pflash_cfi01_register() hides an implicit sysbus mapping of
> MMIO region #0. This is not practical in a heterogeneous world
> where multiple cores use different address spaces. In order to
> remove to remove pflash_cfi01_register() from the pflash API,

duplicated "to remove"

> open-code it as a qdev creation call followed by an explicit
> sysbus mapping.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  hw/arm/collie.c      | 15 +++++++++------
>  hw/arm/gumstix.c     | 19 +++++++++++++------
>  hw/arm/mainstone.c   | 13 ++++++++-----
>  hw/arm/omap_sx1.c    | 22 ++++++++++++++--------
>  hw/arm/versatilepb.c | 13 ++++++++-----
>  hw/arm/z2.c          | 10 +++++++---
>  6 files changed, 59 insertions(+), 33 deletions(-)
>

Otherwise,
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>