Re: [PATCH 01/24] exec/cpu-all: Include missing 'exec/cpu-defs.h' header

[Pierrick Bouvier]

On 11/13/24 17:12, Philippe Mathieu-Daudé wrote:
> TARGET_PAGE_BITS is defined in "exec/cpu-defs.h".
> Include it in order to avoid when refactoring:
>
>    In file included from ../../system/watchpoint.c:23:
>    include/exec/cpu-all.h:356:19: error: use of undeclared identifier 
> 'TARGET_PAGE_BITS'
>      356 | QEMU_BUILD_BUG_ON(TLB_FLAGS_MASK & TLB_SLOW_FLAGS_MASK);
>          |                   ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/exec/cpu-all.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
> index 45e6676938..1c40e27672 100644
> --- a/include/exec/cpu-all.h
> +++ b/include/exec/cpu-all.h
> @@ -136,7 +136,7 @@ static inline void stl_phys_notdirty(AddressSpace *as, 
> hwaddr addr, uint32_t val
>   #endif
>   
>   /* page related stuff */
> -
> +#include "exec/cpu-defs.h"
>   #ifdef TARGET_PAGE_BITS_VARY
>   # include "exec/page-vary.h"
>   extern const TargetPageBits target_page;

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>