qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/24] exec/translation-block: Include missing 'exec/vaddr.h'


From: Pierrick Bouvier
Subject: Re: [PATCH 03/24] exec/translation-block: Include missing 'exec/vaddr.h' header
Date: Wed, 13 Nov 2024 20:10:55 -0800
User-agent: Mozilla Thunderbird

On 11/13/24 17:12, Philippe Mathieu-Daudé wrote:
'vaddr' is declared in "exec/vaddr.h".
Include it in order to avoid when refactoring:

   include/exec/translation-block.h:56:5: error: unknown type name 'vaddr'
      56 |     vaddr pc;
         |     ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  include/exec/translation-block.h | 1 +
  1 file changed, 1 insertion(+)

diff --git a/include/exec/translation-block.h b/include/exec/translation-block.h
index a6d1af6e9b..b99afb0077 100644
--- a/include/exec/translation-block.h
+++ b/include/exec/translation-block.h
@@ -9,6 +9,7 @@
#include "qemu/thread.h"
  #include "exec/cpu-common.h"
+#include "exec/vaddr.h"
  #ifdef CONFIG_USER_ONLY
  #include "qemu/interval-tree.h"
  #endif

I'm a bit confused by commit message, but it seems that this series has some commits that will not compile. Is that something acceptable?

If it's ok,
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]