Re: [PATCH v2 4/9] hw/arm: Include missing 'exec/tswap.h' header

[Richard Henderson]

On 12/11/24 17:03, Philippe Mathieu-Daudé wrote:
> Some files indirectly get "exec/tswap.h" declarations via
> "exec/cpu-all.h". Include it directly to be able to remove
> the former from the latter, otherwise we get:
>
>    hw/arm/boot.c:175:19: error: call to undeclared function 'tswap32'; ISO C99 
> and later do not support implicit function declarations 
> [-Wimplicit-function-declaration]
>      175 |         code[i] = tswap32(insn);
>          |                   ^
>    hw/arm/npcm7xx.c:326:26: error: call to undeclared function 'tswap32'; ISO 
> C99 and later do not support implicit function declarations 
> [-Wimplicit-function-declaration]
>      326 |         board_setup[i] = tswap32(board_setup[i]);
>          |                          ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/arm/boot.c    | 1 +
>   hw/arm/npcm7xx.c | 1 +
>   2 files changed, 2 insertions(+)

These could all be cpu_to_le32, since TARGET_BIG_ENDIAN is always false for 
qemu-system-arm.


r~