Re: [PATCH v2 8/9] hw/xtensa: Include missing 'exec/tswap.h' header

[Richard Henderson]

On 12/11/24 17:03, Philippe Mathieu-Daudé wrote:
> Some files indirectly get "exec/tswap.h" declarations via
> "exec/cpu-all.h". Include it directly to be able to remove
> the former from the latter, otherwise we get:
>
>    hw/xtensa/bootparam.h:40:16: error: call to undeclared function 'tswap16'; 
> ISO C99 and later do not support implicit function declarations 
> [-Wimplicit-function-declaration]
>       40 |         .tag = tswap16(tag),
>          |                ^
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   hw/xtensa/bootparam.h | 1 +
>   hw/xtensa/xtfpga.c    | 1 +
>   2 files changed, 2 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~