Re: [PATCH v2 4/9] hw/arm: Include missing 'exec/tswap.h' header

[Philippe Mathieu-Daudé]

On 12/12/24 00:53, Richard Henderson wrote:
> On 12/11/24 17:03, Philippe Mathieu-Daudé wrote:
> > Some files indirectly get "exec/tswap.h" declarations via
> > "exec/cpu-all.h". Include it directly to be able to remove
> > the former from the latter, otherwise we get:
> >
> >    hw/arm/boot.c:175:19: error: call to undeclared function 'tswap32'; 
> > ISO C99 and later do not support implicit function declarations [- 
> > Wimplicit-function-declaration]
> >      175 |         code[i] = tswap32(insn);
> >          |                   ^
> >    hw/arm/npcm7xx.c:326:26: error: call to undeclared function 
> > 'tswap32'; ISO C99 and later do not support implicit function 
> > declarations [-Wimplicit-function-declaration]
> >      326 |         board_setup[i] = tswap32(board_setup[i]);
> >          |                          ^
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   hw/arm/boot.c    | 1 +
> >   hw/arm/npcm7xx.c | 1 +
> >   2 files changed, 2 insertions(+)
>
> These could all be cpu_to_le32, since TARGET_BIG_ENDIAN is always false 
> for qemu-system-arm.

I agree, but last time I did that Peter insisted for tswap():
https://lore.kernel.org/qemu-devel/CAFEAcA8Exn0VMzM1h048q4Nm7toxkpaOv4B-ZE4FEXKgHoqy7A@mail.gmail.com/

Peter, was my wording in that previous series not clear (in that case
I can try to clarify) or was it OK but you reject the possibility of
using cpu_to_le32() to remove tswap() calls?

(Here my goal is to have a single binary, so I start removing target-
specific endianness).

Thanks,

Phil.