[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 08/48] migration: replace assert(0) with g_assert_not_reached(
From: |
Pierrick Bouvier |
Subject: |
[PATCH v2 08/48] migration: replace assert(0) with g_assert_not_reached() |
Date: |
Thu, 12 Sep 2024 00:38:41 -0700 |
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
migration/migration-hmp-cmds.c | 2 +-
migration/postcopy-ram.c | 14 +++++++-------
migration/ram.c | 6 +++---
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index 28165cfc9ed..20d1a6e2194 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -640,7 +640,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict
*qdict)
visit_type_bool(v, param, &p->direct_io, &err);
break;
default:
- assert(0);
+ g_assert_not_reached();
}
if (err) {
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index 1c374b7ea1e..f431bbc0d4f 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -1411,40 +1411,40 @@ int postcopy_ram_incoming_init(MigrationIncomingState
*mis)
int postcopy_ram_incoming_cleanup(MigrationIncomingState *mis)
{
- assert(0);
+ g_assert_not_reached();
return -1;
}
int postcopy_ram_prepare_discard(MigrationIncomingState *mis)
{
- assert(0);
+ g_assert_not_reached();
return -1;
}
int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb,
uint64_t client_addr, uint64_t rb_offset)
{
- assert(0);
+ g_assert_not_reached();
return -1;
}
int postcopy_ram_incoming_setup(MigrationIncomingState *mis)
{
- assert(0);
+ g_assert_not_reached();
return -1;
}
int postcopy_place_page(MigrationIncomingState *mis, void *host, void *from,
RAMBlock *rb)
{
- assert(0);
+ g_assert_not_reached();
return -1;
}
int postcopy_place_page_zero(MigrationIncomingState *mis, void *host,
RAMBlock *rb)
{
- assert(0);
+ g_assert_not_reached();
return -1;
}
@@ -1452,7 +1452,7 @@ int postcopy_wake_shared(struct PostCopyFD *pcfd,
uint64_t client_addr,
RAMBlock *rb)
{
- assert(0);
+ g_assert_not_reached();
return -1;
}
#endif
diff --git a/migration/ram.c b/migration/ram.c
index 67ca3d5d51a..0aa5d347439 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1765,19 +1765,19 @@ bool ram_write_tracking_available(void)
bool ram_write_tracking_compatible(void)
{
- assert(0);
+ g_assert_not_reached();
return false;
}
int ram_write_tracking_start(void)
{
- assert(0);
+ g_assert_not_reached();
return -1;
}
void ram_write_tracking_stop(void)
{
- assert(0);
+ g_assert_not_reached();
}
#endif /* defined(__linux__) */
--
2.39.2
- [PATCH v2 00/48] Use g_assert_not_reached instead of (g_)assert(0, false), Pierrick Bouvier, 2024/09/12
- [PATCH v2 02/48] hw/acpi: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 03/48] hw/arm: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 01/48] docs/spin: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 06/48] hw/net: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 05/48] hw/core: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 04/48] hw/char: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 07/48] hw/watchdog: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 09/48] qobject: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 08/48] migration: replace assert(0) with g_assert_not_reached(),
Pierrick Bouvier <=
- [PATCH v2 10/48] system: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 12/48] tests/qtest: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 11/48] target/ppc: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 14/48] include/hw/s390x: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 13/48] tests/unit: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 17/48] hw/net: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 15/48] block: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12