[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 12/48] tests/qtest: replace assert(0) with g_assert_not_reache
From: |
Pierrick Bouvier |
Subject: |
[PATCH v2 12/48] tests/qtest: replace assert(0) with g_assert_not_reached() |
Date: |
Thu, 12 Sep 2024 00:38:45 -0700 |
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
tests/qtest/ipmi-bt-test.c | 2 +-
tests/qtest/ipmi-kcs-test.c | 4 ++--
tests/qtest/rtl8139-test.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/ipmi-bt-test.c b/tests/qtest/ipmi-bt-test.c
index 383239bcd48..13f7c841f59 100644
--- a/tests/qtest/ipmi-bt-test.c
+++ b/tests/qtest/ipmi-bt-test.c
@@ -251,7 +251,7 @@ static void emu_msg_handler(void)
msg[msg_len++] = 0xa0;
write_emu_msg(msg, msg_len);
} else {
- g_assert(0);
+ g_assert_not_reached();
}
}
diff --git a/tests/qtest/ipmi-kcs-test.c b/tests/qtest/ipmi-kcs-test.c
index afc24dd3e46..3186c6ad64b 100644
--- a/tests/qtest/ipmi-kcs-test.c
+++ b/tests/qtest/ipmi-kcs-test.c
@@ -145,7 +145,7 @@ static void kcs_cmd(uint8_t *cmd, unsigned int cmd_len,
break;
default:
- g_assert(0);
+ g_assert_not_reached();
}
*rsp_len = j;
}
@@ -184,7 +184,7 @@ static void kcs_abort(uint8_t *cmd, unsigned int cmd_len,
break;
default:
- g_assert(0);
+ g_assert_not_reached();
}
/* Start the abort here */
diff --git a/tests/qtest/rtl8139-test.c b/tests/qtest/rtl8139-test.c
index eedf90f65af..55f671f2f59 100644
--- a/tests/qtest/rtl8139-test.c
+++ b/tests/qtest/rtl8139-test.c
@@ -65,7 +65,7 @@ PORT(IntrMask, w, 0x3c)
PORT(IntrStatus, w, 0x3E)
PORT(TimerInt, l, 0x54)
-#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert(0); } while (0)
+#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert_not_reached(); }
while (0)
static void test_timer(void)
{
--
2.39.2
- [PATCH v2 03/48] hw/arm: replace assert(0) with g_assert_not_reached(), (continued)
- [PATCH v2 03/48] hw/arm: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 01/48] docs/spin: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 06/48] hw/net: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 05/48] hw/core: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 04/48] hw/char: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 07/48] hw/watchdog: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 09/48] qobject: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 08/48] migration: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 10/48] system: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 12/48] tests/qtest: replace assert(0) with g_assert_not_reached(),
Pierrick Bouvier <=
- [PATCH v2 11/48] target/ppc: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 14/48] include/hw/s390x: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 13/48] tests/unit: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 17/48] hw/net: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 15/48] block: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 16/48] hw/hyperv: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 18/48] hw/nvme: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12