[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 14/48] include/hw/s390x: replace assert(false) with g_asse
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v2 14/48] include/hw/s390x: replace assert(false) with g_assert_not_reached() |
|
Date: |
Thu, 12 Sep 2024 13:12:16 +0100 |
On Thu, 12 Sept 2024 at 12:59, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> On 12/9/24 09:38, Pierrick Bouvier wrote:
> > This patch is part of a series that moves towards a consistent use of
> > g_assert_not_reached() rather than an ad hoc mix of different
> > assertion mechanisms.
> >
> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> > ---
> > include/hw/s390x/cpu-topology.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> We usually don't precise "include/" in patch subject:
> we treat include/FOO as part of FOO area.
I would say either is OK -- if you do
git log --oneline | grep ' include' |less
you can see plenty of examples where 'include' was used in
the subject-area prefix, especially if, as here, we're changing
just one file.
-- PMM
- [PATCH v2 05/48] hw/core: replace assert(0) with g_assert_not_reached(), (continued)
- [PATCH v2 05/48] hw/core: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 04/48] hw/char: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 07/48] hw/watchdog: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 09/48] qobject: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 08/48] migration: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 10/48] system: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 12/48] tests/qtest: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 11/48] target/ppc: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 14/48] include/hw/s390x: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 13/48] tests/unit: replace assert(0) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 17/48] hw/net: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 15/48] block: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 16/48] hw/hyperv: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 18/48] hw/nvme: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 19/48] hw/pci: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 22/48] target/i386/kvm: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12
- [PATCH v2 20/48] hw/ppc: replace assert(false) with g_assert_not_reached(), Pierrick Bouvier, 2024/09/12