[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 27/34] hw/net: remove return after g_assert_not_reached()
From: |
Pierrick Bouvier |
Subject: |
[PATCH v3 27/34] hw/net: remove return after g_assert_not_reached() |
Date: |
Wed, 18 Sep 2024 21:46:34 -0700 |
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
hw/net/e1000e_core.c | 2 --
hw/net/igb_core.c | 2 --
hw/net/vmxnet3.c | 1 -
3 files changed, 5 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index 248381f9766..2e4c50ddbaf 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -562,7 +562,6 @@ e1000e_rss_calc_hash(E1000ECore *core,
break;
default:
g_assert_not_reached();
- return 0;
}
return net_rx_pkt_calc_rss_hash(pkt, type, (uint8_t *) &core->mac[RSSRK]);
@@ -841,7 +840,6 @@ e1000e_ring_free_descr_num(E1000ECore *core, const
E1000ERingInfo *r)
}
g_assert_not_reached();
- return 0;
}
static inline bool
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 6be61407715..5dffa12c64b 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -398,7 +398,6 @@ igb_rss_calc_hash(IGBCore *core, struct NetRxPkt *pkt,
E1000E_RSSInfo *info)
break;
default:
g_assert_not_reached();
- return 0;
}
return net_rx_pkt_calc_rss_hash(pkt, type, (uint8_t *) &core->mac[RSSRK]);
@@ -747,7 +746,6 @@ igb_ring_free_descr_num(IGBCore *core, const E1000ERingInfo
*r)
}
g_assert_not_reached();
- return 0;
}
static inline bool
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index bb8583c7aba..8aa8c462283 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -456,7 +456,6 @@ vmxnet3_setup_tx_offloads(VMXNET3State *s)
default:
g_assert_not_reached();
- return false;
}
return true;
--
2.39.5
- [PATCH v3 17/34] hw/acpi: remove break after g_assert_not_reached(), (continued)
- [PATCH v3 17/34] hw/acpi: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 16/34] block: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 18/34] hw/net: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 19/34] hw/scsi: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 20/34] hw/tpm: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 21/34] target/arm: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 22/34] target/riscv: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 23/34] fpu: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 24/34] tcg/loongarch64: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 25/34] include/qemu: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 27/34] hw/net: remove return after g_assert_not_reached(),
Pierrick Bouvier <=
- [PATCH v3 26/34] hw/hyperv: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 28/34] hw/pci: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 29/34] hw/ppc: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 30/34] migration: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 31/34] qobject: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 32/34] qom: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 33/34] tests/qtest: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 34/34] scripts/checkpatch.pl: emit error when using assert(false), Pierrick Bouvier, 2024/09/19