[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 34/34] scripts/checkpatch.pl: emit error when using assert(fal
From: |
Pierrick Bouvier |
Subject: |
[PATCH v3 34/34] scripts/checkpatch.pl: emit error when using assert(false) |
Date: |
Wed, 18 Sep 2024 21:46:41 -0700 |
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
scripts/checkpatch.pl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 65b6f46f905..fa9c12230eb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3102,6 +3102,9 @@ sub process {
if ($line =~ /\b(g_)?assert\(0\)/) {
ERROR("use g_assert_not_reached() instead of
assert(0)\n" . $herecurr);
}
+ if ($line =~ /\b(g_)?assert\(false\)/) {
+ ERROR("use g_assert_not_reached() instead of
assert(false)\n" . $herecurr);
+ }
if ($line =~ /\bstrerrorname_np\(/) {
ERROR("use strerror() instead of strerrorname_np()\n" .
$herecurr);
}
--
2.39.5
- [PATCH v3 25/34] include/qemu: remove return after g_assert_not_reached(), (continued)
- [PATCH v3 25/34] include/qemu: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 27/34] hw/net: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 26/34] hw/hyperv: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 28/34] hw/pci: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 29/34] hw/ppc: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 30/34] migration: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 31/34] qobject: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 32/34] qom: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 33/34] tests/qtest: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 34/34] scripts/checkpatch.pl: emit error when using assert(false),
Pierrick Bouvier <=