[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 30/34] migration: remove return after g_assert_not_reached()
From: |
Pierrick Bouvier |
Subject: |
[PATCH v3 30/34] migration: remove return after g_assert_not_reached() |
Date: |
Wed, 18 Sep 2024 21:46:37 -0700 |
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
migration/dirtyrate.c | 1 -
migration/postcopy-ram.c | 7 -------
migration/ram.c | 2 --
3 files changed, 10 deletions(-)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index c03b13b624f..5478d58de36 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -229,7 +229,6 @@ static int time_unit_to_power(TimeUnit time_unit)
return -3;
default:
g_assert_not_reached();
- return 0;
}
}
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index f431bbc0d4f..0fe9d83d44a 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -1412,40 +1412,34 @@ int postcopy_ram_incoming_init(MigrationIncomingState
*mis)
int postcopy_ram_incoming_cleanup(MigrationIncomingState *mis)
{
g_assert_not_reached();
- return -1;
}
int postcopy_ram_prepare_discard(MigrationIncomingState *mis)
{
g_assert_not_reached();
- return -1;
}
int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb,
uint64_t client_addr, uint64_t rb_offset)
{
g_assert_not_reached();
- return -1;
}
int postcopy_ram_incoming_setup(MigrationIncomingState *mis)
{
g_assert_not_reached();
- return -1;
}
int postcopy_place_page(MigrationIncomingState *mis, void *host, void *from,
RAMBlock *rb)
{
g_assert_not_reached();
- return -1;
}
int postcopy_place_page_zero(MigrationIncomingState *mis, void *host,
RAMBlock *rb)
{
g_assert_not_reached();
- return -1;
}
int postcopy_wake_shared(struct PostCopyFD *pcfd,
@@ -1453,7 +1447,6 @@ int postcopy_wake_shared(struct PostCopyFD *pcfd,
RAMBlock *rb)
{
g_assert_not_reached();
- return -1;
}
#endif
diff --git a/migration/ram.c b/migration/ram.c
index 0aa5d347439..81eda2736a9 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1766,13 +1766,11 @@ bool ram_write_tracking_available(void)
bool ram_write_tracking_compatible(void)
{
g_assert_not_reached();
- return false;
}
int ram_write_tracking_start(void)
{
g_assert_not_reached();
- return -1;
}
void ram_write_tracking_stop(void)
--
2.39.5
- [PATCH v3 20/34] hw/tpm: remove break after g_assert_not_reached(), (continued)
- [PATCH v3 20/34] hw/tpm: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 21/34] target/arm: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 22/34] target/riscv: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 23/34] fpu: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 24/34] tcg/loongarch64: remove break after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 25/34] include/qemu: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 27/34] hw/net: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 26/34] hw/hyperv: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 28/34] hw/pci: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 29/34] hw/ppc: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 30/34] migration: remove return after g_assert_not_reached(),
Pierrick Bouvier <=
- [PATCH v3 31/34] qobject: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 32/34] qom: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 33/34] tests/qtest: remove return after g_assert_not_reached(), Pierrick Bouvier, 2024/09/19
- [PATCH v3 34/34] scripts/checkpatch.pl: emit error when using assert(false), Pierrick Bouvier, 2024/09/19