Re: [Quilt-dev] [PATCH] Add support for zst archives

[Jean Delvare]

On Wed, 2024-01-24 at 13:49 +0100, Jean Delvare wrote:
> On Tue, 2024-01-23 at 12:47 +0100, Andreas Schwab wrote:
> > Add support for zstd compressed archives (*.tar.zst) and patches.
> > ---
> >  quilt/push.in             | 3 +++
> >  quilt/scripts/patchfns.in | 8 ++++++--
> >  quilt/setup.in            | 8 +++++++-
> >  3 files changed, 16 insertions(+), 3 deletions(-)
> > (...)
> > @@ -182,6 +182,12 @@ create_md5sums()
> >                                 set -- $(lzip -cd "$file" | md5sum)
> >                                 echo "$1 $basename"
> >                                 ;;
> > +                       zst*|Zst*)
> 
> I checked the file(1) source code, the returned string for zstd-
> compressed file is "Zstandard compressed data", and has always been
> (since support was added in September 2016). But the command would also
> return "Zstandard dictionary" for zstd dictionary files. So, the "zst*"
> part will never match, and the Zst* part may match file types it
> shouldn't. I would therefore recommend changing the pattern to:
> 
>                       "Zstandard compressed data"*)
> 
> to be on the safe side.

Applied with the change above, thanks for your contribution.

-- 
Jean Delvare
SUSE L3 Support