|
From: | Paolo Bonzini |
Subject: | Re: any interest in Rational Range Interpretation? |
Date: | Sun, 11 Dec 2011 09:32:01 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 |
On 12/10/2011 08:40 PM, Paul Eggert wrote:
the patches are okay with me, but they will only have an effect as long as distributors use --with-included-regexIn that case, they should be combined with --with-included-regex, or with a test that checks that regular expression handling is rational in the system regex code.
But you can't do that as long as --with-included-regex breaks [[=a=] and [[.a.]].
BTW, I reviewed the patch again and the hunk changing regexec is also wrong. If the range handling in system regex code is sane, it will be a nop. If it is not, it will cause unwanted mismatches between two regexes that are similar except one uses backreferences and the other doesn't.
So, the gnulib changes are fine, but not the grep changes. I'll look at them next week.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |