|
From: | Paolo Bonzini |
Subject: | Re: any interest in Rational Range Interpretation? |
Date: | Mon, 12 Dec 2011 08:58:13 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 |
On 12/11/2011 12:24 PM, address@hidden wrote:
> BTW, I reviewed the patch again and the hunk changing regexec is also > wrong.There were no changes to regexec, only in regcomp. Similar in dfa.c.
I meant the hunk removing the regexec calls in dfa.c. It can stay, so the patch you sent for match_mb_charset should be all that's needed for dfa.c. I don't have a testcase because usually dfa.c punts and calls the glibc when it finds a multi-byte bracket.
For regex, you should likewise look for wcscoll in regexec.c and fix it. Here, the testcase should be that for example [d-f] should not match "รจ".
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |