|
| From: | Robert Schuster |
| Subject: | Re: [cp-patches]: Patch: JTree related class' implementations |
| Date: | Tue, 28 Jun 2005 02:28:38 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.7.8) Gecko/20050514 |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Wow, what a huge patch. My nitpicks: - - each author gets a separate @author tag (instead of using commas) - - null and field names in (doc-) comments should be enclosed by <code> - - Instead of comments like "Returns true if largeModel is set" try to explain what the resulting value means for the user of the class. cu Robert -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFCwJm2G9cfwmwwEtoRApcFAKCZBonW6p9koNLGCCpkEYhcIvAQUQCdFUju K7sAGiVmCu8lzQPjUD0a8uQ= =HZc6 -----END PGP SIGNATURE-----
| [Prev in Thread] | Current Thread | [Next in Thread] |