Re: [cp-patches]: Patch: JTree related class' implementations

[Mark Wielaard]

Hi,

On Tue, 2005-06-28 at 12:35 +0200, Roman Kennke wrote:
> It looks like you introduced TABs all over the files. You should never
> use tabs, this may come out very ugly, depending on the user's setting
> of TAB widths.

To keep consistency with other GNU styles and tools indentation uses
tabs and is assumed to be every 8 columns.

> Besides that, it _looks_ ok. Tomorrow I will do some functional tests.
> You should also ask Mark, I think he plans to do a release on Thursday,
> maybe this should go in afterwards.

As long as it compiles and doesn't break the GNU Classpath Swing Example
I am happy with it going in before Thursday.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part