Re: [cp-patches]: Patch: JTree related class' implementations

[Roman Kennke]

Hi Lillian,

Am Montag, den 27.06.2005, 15:45 -0400 schrieb Lillian Angel:
> I have been working on JTree quite a bit.

A bit? The patch is quite big! cool.

Looking briefly over the patch (I cannot make functional tests atm - no
time), I have the following questions/advices in addition to Robert's
remarks:

<<
-/* BasicTreeUI.java --
-   Copyright (C) 2002, 2003, 2004  Free Software Foundation, Inc.
+/* AbstractLayoutCache.java --
+Copyright (C) 2002, 2004  Free Software Foundation, Inc.
>>
Why did you change the copyright statement of BasicTreeUI to
AbstractLayoutCache?

It looks like you introduced TABs all over the files. You should never
use tabs, this may come out very ugly, depending on the user's setting
of TAB widths.

Besides that, it _looks_ ok. Tomorrow I will do some functional tests.
You should also ask Mark, I think he plans to do a release on Thursday,
maybe this should go in afterwards.

Thank you and kind regards,
Roman