Re: [cp-patches]: Patch: JTree related class' implementations

[Lillian Angel]

Here is the updated patch. It is the same as the last patch, but I fixed
some of the errors I had: such as those in the copyright comments, the
author line and all formatting. I allowed eclipse to do the formatting
so there are no TABs lying around. Also one change was made in
DefaultTreeModel.java (see below).

Patch attached. Approval Pending.

2005-06-27  Lillian Angel  <address@hidden>

        * javax/swing/plaf/basic/BasicTreeUI.java:
        (BasicTreeUI): Initalization of listeners and instances.
        (createUI): Implementation
        (getHashColor): Implementation
        (setLeftChildIndent): Implementation
        (getLeftChildIndent): Implementation
        (setRightChildIndent): Implementation
        (getRightChildIndent): Implementation
        (setExpandedIcon): Implementation
        (getExpandedIcon): Implementation
        (setCollapsedIcon): Implementation
        (getCollapsedIcon): Implementation
        (setLargeModel): Implementation
        (isLargeModel): Implementation
        (setRowHeight): Implementation
        (getRowHeight): Implementation
        (setCellRenderer): Implementation
        (getCellRenderer): Implementation
        (setModel): Implementation
        (getModel): Implementation
        (setRootVisible): Implementation
        (isRootVisible): Implementation
        (setShowsRootHandles): Implementation
        (getShowsRootHandles): Implementation
        (setCellEditor): Implementation
        (getCellEditor): Implementation
        (setEditable): Implementation
        (isEditable): Implementation
        (setSelectionModel): Implementation
        (getSelectionModel): Implementation
        (getPathForRow): Implementation
        (getRowForPath): Implementation
        (getRowCount): Implementation
        (getClosestPathForLocation): Implementation
        (createPropertyChangeListener): Implementation
        (createMouseListener): Implementation
        (createFocusListener): Implementation
        (createKeyListener): Implementation
        (createSelectionModelPropertyChangeListener): Implementation
        (createTreeSelectionListener): Implementation
        (createCellEditorListener): Implementation
        (createComponentListener): Implementation
        (createTreeExpansionListener): Implementation
        (createLayoutCache): Implementation
        (createCellRendererPane): Implementation
        (createDefaultCellEditor): Implementation
        (createDefaultCellRenderer): Implementation
        (createTreeModelListener): Implementation
        (uninstallListeners): Implementation
        (getLastChildPath): Implementation
        (configureLayoutCache): Implementation
        (installDefaults): Implementation
        (installListeners): Implementation
        (installUI): Implementation
        (uninstallDefaults): Implementation
        (uninstallUI): Implementation
        (paint): moderate changes, so painting works with new changes
        (MouseInputHandler.mouseClicked): Implementation
        (paintLeaf): made private
        (paintNonLeaf): made private
        (paintRecursive): made private
        Several variables, instances and methods were adding according 
        to the API. The methods that were added and not in the list 
        above, have not been implemented yet. All JavaDoc is updated, 
        as well as formatting.
        * javax/swing/tree/AbstractLayoutCache.java:
        (getNodeDimensions): slight modifications to return initialized 
        Rectangle when the bounds are null. Implementation not complete.
        * javax/swing/tree/DefaultTreeSelectionModel.java:
        (addSelectionPath): Implementation
        (addSelectionPaths): Implementation
        (removeSelectionPath): Implementation
        (removeSelectionPaths): Implementation
        (getSelectionPaths): returned the selection array
        (clearSelection): set the selection array to null
        * javax/swing/tree/FixedHeightLayoutCache.java:
        (setModel): removed this method because it is defined in the 
        abstract parent.
        (setRootVisible): removed this method because it is defined in 
        the abstract parent.
        (setRowHeight): removed this method because it is defined in 
        the abstract parent.
        Also, some formatting was updated.
        * javax/swing/tree/VariableHeightLayoutCache.java:
        (setRowHeight): removed this method because it is defined in 
        the abstract parent.
        * javax/swing/tree/DefaultTreeModel.java:
        (DefaultTreeModel): Needed to initialize root if it was passed 
        into the constructor as null.

On Tue, 2005-06-28 at 14:47 +0200, Mark Wielaard wrote: 
> Hi,
> 
> On Tue, 2005-06-28 at 12:35 +0200, Roman Kennke wrote:
> > It looks like you introduced TABs all over the files. You should never
> > use tabs, this may come out very ugly, depending on the user's setting
> > of TAB widths.
> 
> To keep consistency with other GNU styles and tools indentation uses
> tabs and is assumed to be every 8 columns.
> 
> > Besides that, it _looks_ ok. Tomorrow I will do some functional tests.
> > You should also ask Mark, I think he plans to do a release on Thursday,
> > maybe this should go in afterwards.
> 
> As long as it compiles and doesn't break the GNU Classpath Swing Example
> I am happy with it going in before Thursday.
> 
> Cheers,
> 
> Mark

current.diff
Description: Text Data