Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets

[joakim]

address@hidden writes:

> Paul Eggert <address@hidden> writes:
>
>> address@hidden wrote:
>>> There seems to be a bunch of gtk warnings I cant really do anything about.
>>
>> You should be able to fix them all.  The attached patch did that for
>> me, on Ubuntu 14.10 anyway.  This patch uses the usual GNU Emacs style
>> in the code I fixed; similar fixes are needed for the rest of the
>> xwidget code, but one thing at a time.)
>
> Cool, with your advice I was able to fix all the warnings!
> I pushed such a patch (similar to yours) to the repo now.
>
> Next I will run gnu indent.

Running indent didn't work out too well.

I get stuff like this:

xwidget.c: In function ‘Fmake_xwidget’:
xwidget.c:221:3: error: ‘Vxwidget_list’ undeclared (first use in this function)
   Vxwidget_list = Fcons (val, Vxwidget_list);
   ^


I'm guessing gnu indent breaks some Emacs build macrology.

Any hints?

>
>>
>>>    --enable-gtk-deprecation-warnings
>>>
>>> seems to be good as well.
>>
>> That's disabled by default due to its false alarms.  It is helpful to
>> enable it occasionally, and you can still build despite the warnings
>> by using 'make WERROR_CFLAGS='.  I don't recommend this for ordinary
>> development, though.
>>
>>

-- 
Joakim Verona