Re: [ft-devel] Position Independent Port of FreeType2

[Werner LEMBERG]

> >   . Please stay in the 78 column width limit.  At least one
> >     C preprocessor doesn't like
> >
> >        #define FOO( bar, \
> >                     baz ) ...
> >
> >     but this is a bug in this program, so we don't care.
>
> So I should stay in 78 columns even thought there is a buggy
> preprocessor that does like it, right?

Yep.

> >     So please add proper
> >
> >       while ( 0 ) do { <macro body> }
> >
> >     constructs where necessary.
>
> I certainly don't mind, but it seems that the while trick would only
> work with macros that are inside function bodies.  Most of the
> macros I made either define program level functions or structs.
> While most of them look like a function, they definitely cannot be
> used as functions.

Well, then please add comments.

> The correct fix would be using different render functions for
> render1 and render5, which would then do the relevant checks and
> then call the real function.  This would cost in one additional
> function call per glyph rendering.  My guess is that the original
> check was done to avoid this cost (which is why even my PIC code
> uses a slightly different hack).
>
> If the additional function call cost seems acceptable, I can submit
> such a patch that separates to two different functions.

Hmm.  `raster5' is rather obsolete and only exists for backwards
compatibility.

> However this hack is really not very bad or hairy, as hacks go. It
> is easy to figure out and not very likely to break. You could just
> as well leave it there.

OK. Let it as-is.

> There is an area of FT2 that I am totally unfamiliar with, and that
> is the make / jam based build system.  So far I've been building my
> own custom version with the instructions in INSTALL.ANY.  Do you
> think the PIC change would need special care to be "back ported"
> into the make files? (For example I saw some module related
> definitions in various .mk files.)

I don't think so.  The only generated file is ftmodule.h which looks
similar to the one distributed with the FreeType bundle.

One remark I've omitted last time: Please always check whether your
changes work with a C++ compiler (this is, using a C++ compiler
instead of a C compiler for compiling FreeType).


    Werner