Re: [Gap-dev-discuss] Cynthiune - Current known problems to solve before release

[Sebastian Reitenbach]

On Monday, May 14, 2012 12:33 CEST, Riccardo Mottola <address@hidden> wrote:

> Hi,
>
> On 05/14/12 12:25, Philippe Roussel wrote:
> > Hi,
> >
> > Just some comments.
> >
> > Le 14/05/2012 09:41, Riccardo Mottola a écrit :
> >> Hi,
> >>
> >> let's try to sum up.. and then I propose a separate mail thread for
> >> discussion, proposals fixes.
> >>
> >> 1) Resetting properties of backends (channels, rate and endianness).
> >> Philippe proposes to reopen the device, perhaps it can be reset. Affects
> >> 2) in the term that if endianness changes during playing there are
> >> troubles. Affected are ALSA for sure, AO perhaps...
> >> 2) Endianness. I hope this is mainly sorted out for most backends? I
> >> fear only me and Sebastian can check that
> >> 3) Shuffle/Repeat. Selecting the Menu-action and the toolbar action do
> >> not highlight the same way...
> >> 4) Long delays when passing to one song to the other, experienced at
> >> least for ALSA. It could be related to 1) since each time I get an
> >> exception...
> >> 5) Sndio not working at all for me (will retest again tomorrow)
> >> 6) Gorm file is bogus, will ask for help.
> >> 7) Crashes/memory issues. Yesterday i still got a crash after playing
> >> several files (I brought my old debian laptop with Cynthiune to a sound
> >> studio and used it as a sound input... it plays quite well!!!)
> > I'll work on 1), 4) and 7) (ie ALSA and general crashes) as I can't help
> > with endianness or gorm issues.
> >
> > I will open other threads if/when I find something useful.
> Fine. I suppose 1-4-7 are actually closely related. Do you get
> errors/warnings when changing songs (even same
> channels/ratio/endianness)? I get them on x86 too and I guess that won
> ppc where endianness is involved too, things get worse.
>
> Please send separate patches, it is easier for review! And if you
> include your name and notice in the Changelog, you'll get the credits
> too :) (And save me work, since I anyway write ChangeLogs)
>
> >
> >> Fixed problem which we should confirm are
> >> 1) opening/saving playlists
> >> 2) object deduplication
> > Works for me, even if deduplication is only based on file path right now.
> Yes, but it is enough, I'd say. Seems to work for me. One drawback is
> that if you have a default playlist with duplicates, Cynthiune will

> crash at startup.

I have seen that too, but unfortunately deleted my playlist file, instead of 
moving
it out of the way. How about the patch below. Instead of throwing an exception,
just spit out a message on the console about skipping the song, then go on
with the next.
Have it only tested with loading a m3u file with double entries, but not one
on startup. Hope one of you still may have such a bogus file around.

Sebastian



Index: Playlist.m
===================================================================
RCS file: /sources/gap/gap/user-apps/Cynthiune/Playlist.m,v
retrieving revision 1.2
diff -u -r1.2 Playlist.m
--- Playlist.m  13 May 2012 16:56:42 -0000      1.2
+++ Playlist.m  14 May 2012 17:00:44 -0000
@@ -103,8 +103,7 @@
 - (void) addSong: (Song *) song
 {
   if ([list containsObject: song])
-    raiseException (@"Duplicate song", @"a given song can be added only"
-                    @" once to the same playlist");
+    NSLog(@"Skipping duplicate song: %@", [song filename]);
   else
     {
       [list addObject: song];
@@ -132,9 +131,7 @@
           if ([song isKindOfClass: [Song class]])
             {
               if ([list containsObject: song])
-                raiseException (@"Duplicate song",
-                                @"a given song can be added only once to"
-                                @" the same playlist");
+               NSLog(@"Skipping duplicate song: %@", [song filename]);
               else
                 {
                   if (!firstSong)
@@ -160,8 +157,7 @@
             atIndex: (unsigned int) index
 {
   if ([list containsObject: song])
-    raiseException (@"Duplicate song", @"a given song can be added only"
-                    @" once to the same playlist");
+    NSLog(@"Skipping duplicate song: %@", [song filename]);
   else
     {
       [list insertObject: song atIndex: index];





>
> >
> >> I'd love to revive the Mac version, but I don't know how to handle
> >> dependencies. Even if with just one backend (I was able to compile MP3
> >> library, but not audiofile) to check the code.
> >>
> >> We can also add a feature wishlist for the next release, but I want to
> >> get this one out soon. For that I want
> >> 1) sort out musicbrainz stuff
> >> 2) include audiocd support?
> >> 3) preference panel for timidity and better handling of it
> >> 4) context menus...
> >> 5) ID3tag editing (integration with POE... more info about that
> >> separately, after the release! :)
> > Maybe I didn't get understand you correctly but in my opinion all these
> > points shouldn't block a release, unless they make Cynthiune crash. But
> > all of them would be welcome in a future release of course !
> Sorry, I wasn't clear. These were suggestions for new releases :)
>
> Riccardo
>
>