Re: [Gnash-dev] [PATCH] Initial implementation of a cairo renderer

[Paul Smedley]

Hi Bastiaan (& Timothy)

On 2/5/2006, "Bastiaan Jacques" <address@hidden> wrote:

>On Tuesday 02 May 2006 09:45, Timothy Lee wrote:
>>     m_texture_id = (unsigned int)cairo_pattern_create_for_surface(m_image);
>
>This is a cast from a pointer to 32-bit integer, which is 64-bit unsafe. I've 
>added an m_pattern member to replace m_texture_id.
>
>I've added a configure option --enable-renderer=[renderer], where renderer is 
>either opengl or cairo (the default is still opengl).
>
>This work increases the importance of a cleanup of gnash.cpp (which is already 
>underway in the form of a frontend library) - when the cairo backend is 
>enabled, currently two windows are created. Fixing that is nontrivial due to 
>the goop in gnash.cpp.

Great work - I'll try this out in the next few days on OS/2. We don't
have a current port of mesagl for opengl, but do have an up to date
Cairo build.

Cheers,

Paul