Re: [Gnu-arch-users] libtla

[Brian May]

>>>>> "Tom" == Tom Lord <address@hidden> writes:

    Tom> I'm glad Jeremy replied to your original message because I seem to
    Tom> have accidentally deleted it while catching up with mail.

Would you prefer I CC you mails as appropriate? Generally I don't for
mailing list posts, some people get annoyed :-(.

    Tom> I haven't looked at it yet.   If you want to declare that you've hit a
    Tom> milestone and that I should look at it as a merge request I will.

No, not there yet...

    Tom> So: is your work on step 2a ready for merging?  Have you used `nm' and
    Tom> some shell tools to verify that the call-graph layering worked out
    Tom> correctly?

I am unfamiliar with using nm to check the call graph in this manner,
my checks are a bit more primitive, but hopefully accurate(?).

    Tom> It would be helpful if you could list which files and functions you've
    Tom> put into libarch-utils.

Ok, my "incomplete" checks so far are:

* it compiles and links

* I have checked that nothing in libarch-utils/* includes any include files
from libarch-cmds/*:

>tla inventory --source libarch-utils | xargs grep 'libarch-cmds\/'
[ no output ]

* I have checked that nothing in libarch/* includes any include files
from libarch-cmds/*:

>tla inventory --source libarch | xargs grep 'libarch-cmds\/'
[ no output ]

The files I have are (note: every *.h file has a corresponding *.c file):

libarch-utils/changelogs.h    libarch-utils/my.h
libarch-utils/inode-sig.h     libarch-utils/namespace.h
libarch-utils/invent.h        libarch-utils/patch-logs.h
libarch-utils/inv-ids.h       libarch-utils/project-tree.h
libarch-utils/merge-points.h

libarch-cmds/apply-changeset.h          libarch-cmds/cmd-library-revisions.h
libarch-cmds/arbdelta.h                 libarch-cmds/cmd-library-versions.h
libarch-cmds/archive-cache.h            libarch-cmds/cmd-lock-pristine.h
libarch-cmds/archive-setup.h            libarch-cmds/cmd-lock-revision.h
libarch-cmds/build-revision.h           libarch-cmds/cmd-log-for-merge.h
libarch-cmds/cmd-abrowse.h              libarch-cmds/cmd-logs.h
libarch-cmds/cmd-add-id.h               libarch-cmds/cmd-log-versions.h
libarch-cmds/cmd-add-log-version.h      libarch-cmds/cmd-make-archive.h
libarch-cmds/cmd-add-pristine.h         libarch-cmds/cmd-make-branch.h
libarch-cmds/cmd-ancestry-graph.h       libarch-cmds/cmd-make-category.h
libarch-cmds/cmd-ancestry.h             libarch-cmds/cmd-make-log.h
libarch-cmds/cmd-apply-changeset.h      libarch-cmds/cmd-make-version.h
libarch-cmds/cmd-apply-delta.h          libarch-cmds/cmd-merges.h
libarch-cmds/cmd-archive-fixup.h        libarch-cmds/cmd-missing.h
libarch-cmds/cmd-archive-meta-info.h    libarch-cmds/cmd-move-id.h
libarch-cmds/cmd-archive-mirror.h       libarch-cmds/cmd-mv.h
libarch-cmds/cmd-archive-setup.h        libarch-cmds/cmd-my-default-archive.h
libarch-cmds/cmd-archives.h             libarch-cmds/cmd-my-id.h
libarch-cmds/cmd-archive-snapshot.h     libarch-cmds/cmd-my-revision-library.h
libarch-cmds/cmd-archive-version.h      libarch-cmds/cmd-new-merges.h
libarch-cmds/cmd-branches.h             libarch-cmds/cmd-parse-package-name.h
libarch-cmds/cmd-build-config.h         libarch-cmds/cmd-pristines.h
libarch-cmds/cmd-cachedrevs.h           libarch-cmds/cmd-rbrowse.h
libarch-cmds/cmd-cacherev.h             libarch-cmds/cmd-redo.h
libarch-cmds/cmd-cat-archive-log.h      libarch-cmds/cmd-register-archive.h
libarch-cmds/cmd-cat-config.h           libarch-cmds/cmd-remove-log-version.h
libarch-cmds/cmd-categories.h           libarch-cmds/cmd-replay.h
libarch-cmds/cmd-cat-log.h              libarch-cmds/cmd-revisions.h
libarch-cmds/cmd-changelog.h            libarch-cmds/cmd-rm.h
libarch-cmds/cmd-changeset.h            libarch-cmds/cmd-set-tree-version.h
libarch-cmds/cmd-changes.h              libarch-cmds/cmds.h
libarch-cmds/cmd-commit.h               libarch-cmds/cmd-show-changeset.h
libarch-cmds/cmd-default-id.h           libarch-cmds/cmd-star-merge.h
libarch-cmds/cmd-delete-id.h            libarch-cmds/cmd-sync-tree.h
libarch-cmds/cmd-delta.h                libarch-cmds/cmd-tag.h
libarch-cmds/cmd-file-diffs.h           libarch-cmds/cmd-tree-lint.h
libarch-cmds/cmd-file-find.h            libarch-cmds/cmd-tree-root.h
libarch-cmds/cmd-find-pristine.h        libarch-cmds/cmd-tree-version.h
libarch-cmds/cmd-get-changeset.h        libarch-cmds/cmd-uncacherev.h
libarch-cmds/cmd-get.h                  libarch-cmds/cmd-undo.h
libarch-cmds/cmd-grab.h                 libarch-cmds/cmd-update.h
libarch-cmds/cmd-help.h                 libarch-cmds/cmd-valid-package-name.h
libarch-cmds/cmd-id.h                   libarch-cmds/cmd-versions.h
libarch-cmds/cmd-id-tagging-defaults.h  libarch-cmds/cmd-whereis-archive.h
libarch-cmds/cmd-id-tagging-method.h    libarch-cmds/commit.h
libarch-cmds/cmd-import.h               libarch-cmds/configs.h
libarch-cmds/cmd-init-tree.h            libarch-cmds/file-diffs.h
libarch-cmds/cmd-inventory.h            libarch-cmds/import.h
libarch-cmds/cmd-join-branch.h          libarch-cmds/library-txn.h
libarch-cmds/cmd-library-add.h          libarch-cmds/local-cache.h
libarch-cmds/cmd-library-archives.h     libarch-cmds/make-changeset-files.h
libarch-cmds/cmd-library-branches.h     libarch-cmds/make-changeset.h
libarch-cmds/cmd-library-categories.h   libarch-cmds/pristines.h
libarch-cmds/cmd-library-config.h       libarch-cmds/replay.h
libarch-cmds/cmd-library-file.h         libarch-cmds/star-merge.h
libarch-cmds/cmd-library-find.h         libarch-cmds/sync-tree.h
libarch-cmds/cmd-library-log.h          libarch-cmds/tag.h
libarch-cmds/cmd-library-remove.h       libarch-cmds/undo.h

I moved all cmd-* files into libarch-cmds. Any file that included a
file already in libarch-cmds I moved here, too.

libarch/ancestry.h           libarch/editor.h
libarch/archive.h            libarch/exec.h
libarch/archive-mirror.h     libarch/hooks.h
libarch/archive-pfs.h        libarch/libraries.h
libarch/archives.h           libarch/missing.h
libarch/archive-snapshot.h   libarch/pfs-dav.h
libarch/archive-version.h    libarch/pfs-fs.h
libarch/cached-inventory.h   libarch/pfs-ftp.h
libarch/changeset-report.h   libarch/pfs.h
libarch/changeset-utils.h    libarch/pfs-sftp.h
libarch/chatter.h            libarch/pfs-signatures.h
libarch/cmd.h                libarch/proj-tree-lint.h
libarch/cmdutils.h           libarch/sftp.h
libarch/copy-project-tree.h  libarch/whats-new.h
libarch/diffs.h

I am uncertain how to classify these files, except I think all of them
could go into libarch-utils, as far as I can tell, nothing here depends
on libarch-cmds.

I suspect *pfs*.h and sftp.h stuff should be moved into libarch-cmds,
at the minimum.
-- 
Brian May <address@hidden>