Re: [Gnu-arch-users] tla undo feature request

[Ben Burns]

On Sun, 27 Jun 2004 20:55:43 -0400, Aaron Bentley
<address@hidden> wrote:

> 
> Ben Burns wrote:
> 
> > It makes
> > sense to me to add the file mode to the inode sigs...  after doing
> > this, and rebuilding my revision libraries, I haven't seen any files
> > in the revision library with the wrong file permission go unnoticed by
> > tla.
> 
> Great.  We've been meaning to add that support to inode-sigs, just that
> no one's written the code yet.  Feel like getting Tom's requirements and
> submitting a patch?

Well, I would like to, but my laptop (my only machine) died a couple
of months back... I am still in the stage of recovering the data off
the disk and backing up before I can set up this machine (new
desktop)...  With time being as it is though,  I am probably a few
weeks away from being able to do anything... :(

However, the good news is that I already have a publicly mirrored
branch with this change on sourcecontrol.

The archive is address@hidden  Some documentation is
on the wiki at http://wiki.gnuarch.org/address@hidden
 tla--library-share--1.3 contains the file mode in inode sigs fix...

Unfortunately, this branch is an integration branch with one patch
containing lots of changes.  My dev archive is not currently
available, so cherry picking the change will not be possible...  Only
the changes to inode-sigs.c are relavent though, so this should make
it easy if you don't want the entire changeset.

I was not able / did not consider making this change backward
compatible with previous inode sig formats.... Mainly because I would
consider an inode sig without a mode field as being broken (unsafe)
anyway.  (For that matter, would be nice for tla to consider missing
inode sigs as corrupt too....).  So, you are forced to rebuild your
revision libraries after this change.

So if someone can look at that and create a patch suitable for Tom, it
would be appreciated... otherwise I can look at it again in a month or
so.  Of course, I wouldn't mind if the entire patch was included
either ;)

Thanks,
Ben