Re: Transformation experiments

[Han-Wen Nienhuys]

Erlend Aasland wrote:
> On 5/5/06, *Han-Wen Nienhuys* <address@hidden 
> <mailto:address@hidden>> wrote:
>
>      > ... the problem is more about what variables to modify. It
>      > appears to me like dim_ contains the bounding box, but when I
>     modify it,
>      > the rotated stencils are misplaced.
>
>     strange. are you sure you're not seeing artefacts of the fact that
>     placements algorithms look at the bbox to determine offsets?
>
>
> I found the bug: the "misplacements" came from TextScript 
> #'staff-padding :-)
>
> Anyway, I've fixed a couple of bugs in the implementation and attached a 
> bugfree (I hope) version of the patch. Enjoy.

ok, nits that need to be addressed before integrating:

 - stencil::rotate should take Offset() as argument.

 - I think widen() can also shrink the bbox, can you double check that
your scaling routine doesn't shrink the bbox?  (x_new - x_len)  looks 
suspect to me.  Why don't you rotate the 4 corners and use add_point() 
on an empty box?

 - for rotation use  offset * complex_exp(angle)

 - the  scheme binding misses the offset arg

 - SVG support !



--

Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen

LilyPond Software Design
 -- Code for Music Notation
http://www.lilypond-design.com