Re: my apologies: incorrectly modified source code

[Valentin Villenave]

2008/1/13, Graham Percival <address@hidden>:
> Sorry everybody, there was a miscommunication between me and
> Valentin.
>
> Some with a git clue: the following commits were not properly
> reviewed.  Could they be revoked / uncommitted ?
>
> 4fb83031bac58babe2f6a1eea92af286a4469d1a
> c2b8039d1d227a1d20b7a9a3fb04d8df8e40de19
> 5319128636bbc8f11284249364fda530334c81ba
> 9800152af3a902baa4b2fd11032355b2aee08e49
> b782c06b863efdf4e622009a27978d473442cb0e
> 3c98dad2fcce939ba703380b69aa4d0c03b5fdf2
> 639110b0c4e90269ed49f354941b1e1161af0dda
>
>
> Valentin, unless you've heard otherwise from Han-Wen, please do
> not touch the source code -- even if there's a really simple patch
> in the tracker.  (*especially* if it comes from somebody with git
> access, like Joe.  He evidently thought he shouldn't commit these
> without Han-Wen reviewing them.)

He mentioned he would commit them himself if he had proper internet
access, but he happened to be in an internet cafe. I thought it might
be appropriate for me to commit it, as it was a couple of bugfixes. As
I mentioned in the comments, I'm sorry if I ruined anything.

John had recently told me I should only use git to commit really
useful stuff; I thought "hey! this could be it!" :)

Valentin