Re: PATCH: Consolidate autobeaming to one property that controls it

[Jonathan Kulp]

Carl Sorensen wrote:
> At *long* last I have completed my changes to the autobeaming rules.
>
> The rietveld patch set is available at:
>
> http://codereview.appspot.com/88155
>
>
> The objective is to get all information that affects autobeaming in a single
> place, so a single override will adjust the autobeam settings.
>
> Autobeam settings also affect measure grouping, so the
> measure_grouping_engraver needed to be rewritten as well.
>
> Once the dust for this patch has settled, I will then attack the beam
> subdivision code.
>
> Please review this extensive patch and give me comments.
>
> Thanks,
>
> Carl

Carl, thanks so much for working on this important issue! I've 
applied the scheme patches and will experiment a bit later. FYI 
there were some whitespace warnings when applying the patches. 
I'll copy the terminal output below so you can see.

Jon

--
Jonathan Kulp
http://www.jonathankulp.com

address@hidden:~/lilypond$ git apply issue88155_1_20.diff
issue88155_1_20.diff:280: trailing whitespace.
;;  3. if 1-2 not specified, begin anywhere, end at beatLength 
intervals
issue88155_1_20.diff:371: trailing whitespace.
                 (time-signature-fraction
issue88155_1_20.diff:381: trailing whitespace.
                 (grouping-rules
warning: 3 lines add whitespace errors.
address@hidden:~/lilypond$ git apply issue88155_1_21.diff
issue88155_1_21.diff:38: trailing whitespace.
   (((2 . 2) end) .
issue88155_1_21.diff:47: trailing whitespace.

issue88155_1_21.diff:51: trailing whitespace.
   (((3 . 2) end) .
issue88155_1_21.diff:68: trailing whitespace.
   (((4 . 2) end) .
issue88155_1_21.diff:80: trailing whitespace.
   (((4 . 4) end) .
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.
address@hidden:~/lilypond$ git apply issue88155_1_22.diff
address@hidden:~/lilypond$ git apply issue88155_1_23.diff
issue88155_1_23.diff:21: trailing whitespace.
beams should begin and end, as well as beam subdivision behavior.
warning: 1 line adds whitespace errors.
address@hidden:~/lilypond$ git apply issue88155_1_24.diff
address@hidden:~/lilypond$ git apply issue88155_1_25.diff
issue88155_1_25.diff:66: trailing whitespace.
      (ly:export
issue88155_1_25.diff:70: trailing whitespace.
               (make-apply-context
issue88155_1_25.diff:73: trailing whitespace.
                                (list (cons num den) 'end)
warning: 3 lines add whitespace errors.