[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PATCH: Consolidate autobeaming to one property that controls it
From: |
Neil Puttock |
Subject: |
Re: PATCH: Consolidate autobeaming to one property that controls it |
Date: |
Sun, 12 Jul 2009 16:43:06 +0100 |
2009/7/12 Carl Sorensen <address@hidden>:
> I've created a second patch set with the whitespace removed (along with
> automatic removal of whitespace from the lines of the files that weren't
> part of the patch).
Brilliant work, Carl!
I'll comment on individual issues in Rietveld shortly.
I notice you've changed the autobeaming for 4/8; is this deliberate?
Is it possible to fix the output from \displayLilyMusic for \time and
set-time-signature?
\displayLilyMusic { \time 3/4 }
{ \context Score { \set Timing . timeSignatureFraction = #(cons 3 4)
\set Timing . beatLength = #(ly:make-moment 1 4 0 1)
\set Timing . measureLength = #(ly:make-moment 3 4 0 1)
} }
should be
{ \time 3/4 }
>
> I've also fixed up the mistakes I made in the headers of the lsr snippets,
> so there won't be double translations.
Where are the input/new snippets these are generated from (there's
only one in the patch set)?
Regards,
Neil
Re: PATCH: Consolidate autobeaming to one property that controls it, Jonathan Kulp, 2009/07/11