Re: Can't build today's git pull

[Peter Chubb]

>>>>> "Graham" == Graham Percival <address@hidden> writes:

Graham> On Thu, Feb 18, 2010 at 09:47:21AM +1100, Peter Chubb wrote:
>> ...  chmod 755 out/convert-ly
>> /usr/src/lilypond/scripts/build/out/help2man out/convert-ly >
>> out/convert-ly.1 out/convert-ly:341: Warning: 'as' will become a
>> reserved keyword in Python 2.6 File "out/convert-ly", line 341
>> except InvalidVersion as ex: ^ SyntaxError: invalid syntax
>> help2man: can't get `--help' info from out/convert-ly

Graham> Are you sure that's a build **failure**, and not just a
Graham> **warning**?  I think I remember seeing the "help2man: can't
Graham> get --help" error for years.

It's a build failure -- make just stops at that point.



>> This is with python version 2.5.5
>> 
>> I suggest this patch, which *should* work with both 2.6 and 2.5
>> (but warning: I am *not* a python programmer).

Graham> I'm not a python programmer either, but git must (and has
Graham> been) compile with python 2.4.5.  (unless anybody updates the
Graham> package in GUB)

Graham> 2.13.13 definitely compiled with 2.4.5, and I can't remember
Graham> any changes to convert-ly since then.


Reinhold made a change to convert-ly as the last change in the stack
before I pulled this morning (my time), to add an exception for a
malformed version string.  But he used a Python 3.0 feature, which my
patch fixes:
  
  commit 55ee5f274895295ae79d555d6dcc9ab84ecf270e
  Author: Reinhold Kainhofer <address@hidden>
  Date:   Thu Dec 31 12:20:41 2009 +0100

    convert-ly: Raise an error message if version number is not a
        three-entry tuple 
    
    This fixes crashes with things like
       \version "2.10"
    or
       \version "2.10.4.3.21"
    and instead gracefully reminds the user that version strings should have a
    form like `2.8.12'


--
Dr Peter Chubb        www.nicta.com.au      peter DOT chubb AT nicta.com.au
http://www.ertos.nicta.com.au           ERTOS within National ICT Australia
From Imagination to Impact                       Imagining the (ICT) Future