Re: Can't build today's git pull

[Reinhold Kainhofer]

Am Donnerstag, 18. Februar 2010 19:31:06 schrieben Sie:
> On Wed, Feb 17, 2010 at 11:24 PM, Peter Chubb <address@hidden> 
wrote:
> >>> /usr/src/lilypond/scripts/build/out/help2man out/convert-ly >
> >>> out/convert-ly.1 out/convert-ly:341: Warning: 'as' will become a
> >>> reserved keyword in Python 2.6 File "out/convert-ly", line 341
> >>> except InvalidVersion as ex: ^ SyntaxError: invalid syntax
> >>> help2man: can't get `--help' info from out/convert-ly
> > 
> > Graham> Are you sure that's a build **failure**, and not just a
> > Graham> **warning**?  I think I remember seeing the "help2man: can't
> > Graham> get --help" error for years.
> > 
> > It's a build failure -- make just stops at that point.
> 
> Interesting!  If I build with GUB, the installer builds (no compile
> error), but trying to run convert-ly from that installer fails:
> 
> address@hidden:~/tmp$ convert-ly -e lily.ly
>   File "/home/gperciva/.usr/lilypond/usr/bin/convert-ly", line 341
>     except InvalidVersion as ex:
>                            ^
> SyntaxError: invalid syntax


Hmm, sorry... Apparently, code reviews don't catch such things, either.


> I won't pretend to know how python 2.4, 2.5, 2.6, 3.0 and 3.1 all
> treat this syntax, so could somebody who knows python take a look at
> the current convert-ly and make it work on 2.4.5 and up?

From the docs at python.org it seems like the comma syntax for exception 
variables works also with 2.4. But as I don't have any python 3.x around, I 
can't tell whether it still works with 3.0 and 3.1 (the docs completely 
switched to using "as" instead...).

Cheers,
Reinhold


-- 
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org