lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

code review is a good.


From: Graham Percival
Subject: code review is a good.
Date: Thu, 4 Mar 2010 11:44:30 +0000

We are not amused.  GUB fails with:

  File 
"/main/src/gub/target/linux-x86/build/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/python/out/lilylib.py",
line 52, in encoded_write
    f.write (s
TypeError: decode() argument 1 must be string, not None


I've therefore reverted this commit:

commit 0ce2657b47ac6ba152ee022b27de26e569846db9
Author: Valentin Villenave <address@hidden>
Date:   Wed Mar 3 12:02:09 2010 +0100

    convert-ly: fix bug with accented filenames

    converty-ly couldn't cope with accented filenames
    (reported by Nick Payne on Jan 4, 2010).  This seems
    to do the trick (albeit in a probably non-orthodox way).

    Tested on MS Windows (Python 2.4) and GNU/Linux
    (Python 2.6).


- Graham




reply via email to

[Prev in Thread] Current Thread [Next in Thread]