Re: vert. spacing: Rename properties (lily, scm). (issue3031041)

[Carl . D . Sorensen]

On 2010/11/12 09:06:06, Trevor Daniels wrote:



http://codereview.appspot.com/3031041/diff/40001/lily/axis-group-interface.cc#newcode780
> lily/axis-group-interface.cc:780: "The following keys may be set in
the spacing
> alists:\n"
> I'm not sure.  The current description is in the interface.

If you look at the delta from set 12, you think the current description
is in the interface.  If you look at the delta from master, you'll find
there is no description in the interface currently.

> Isn't the standard practice to place descriptions in the interface and
only the
> values set for particular grobs in the grob description?  (I was about
to say we
> should do the same as 'details, but the description of 'details is
very poor;
> not a good model.)

As far as I can see, the only time we place descriptions in the
interface is when the property can have different values depending on
the interface in which it's used (as in 'details).  So the
beam-interface has a list of the 'details that can be set for beams.

In this case, the spacing-alist has the same entries for all the
interfaces, so there's no need to repeat the information in the
different interfaces.  The best place to put the definition, IMO, is in
the description of the spacing property that is either most general or
most commonly set.  See the current behavior in the IR, section 3.3, of
between-staff-spacing and next-staff-spacing.

break-aligned-interface currently has the definition of space
specifications in the interface description.  I think it would be nicer
to have the space specifications as part of the description of the
space-alist property, where it would describe the distance element of
the tuples in the space-alist.

The reasoning behind this is that when it's done this way, every time we
see the space-alist, we have the explanation, without having to
duplicate the information in each interface that uses space-alist.
Furthermore, if I'm looking at the space-alist property, I know how to
set its entries without having to find the interface.

Thanks,

Carl





http://codereview.appspot.com/3031041/