Re: Add tab-tie-follow-engraver (issue2723043)

[Carl . D . Sorensen]

Thanks for the feedback.  I've responded to the comments and posted a
new patch set.


http://codereview.appspot.com/2723043/diff/109001/lily/tab-harmonic-engraver.cc
File lily/tab-harmonic-engraver.cc (left):

http://codereview.appspot.com/2723043/diff/109001/lily/tab-harmonic-engraver.cc#oldcode83
lily/tab-harmonic-engraver.cc:83: "HarmonicParenthesesItem ",
On 2010/11/28 22:24:05, Neil Puttock wrote:
> This is never created, even for \tabFullNotation.

Deleting the engraver solved this issue

http://codereview.appspot.com/2723043/diff/109001/lily/tab-harmonic-engraver.cc
File lily/tab-harmonic-engraver.cc (right):

http://codereview.appspot.com/2723043/diff/109001/lily/tab-harmonic-engraver.cc#newcode59
lily/tab-harmonic-engraver.cc:59: victim->set_property ("style",
ly_symbol2scm ("harmonic"));
On 2010/11/28 22:24:05, Neil Puttock wrote:
> This makes it difficult for users to tweak the appearance of the
harmonic
> brackets, though if you still think it's a price worth paying, you
might as well
> junk the engraver and read 'articulations directly inside the notehead
callback.

I junked the engraver and added properties to the tab-note-head 'details
for cautionary and harmonic brackets.

http://codereview.appspot.com/2723043/diff/109001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/2723043/diff/109001/scm/define-grob-properties.scm#newcode965
scm/define-grob-properties.scm:965: (display-cautionary ,boolean?
"Display as cautionary.")

On 2010/11/28 22:24:05, Neil Puttock wrote:
> Needs a more descriptive docstring.

Tried to make it more descriptive, but I didn't want it to be limited to
tab-note-head.

http://codereview.appspot.com/2723043/diff/109001/scm/tablature.scm
File scm/tablature.scm (right):

http://codereview.appspot.com/2723043/diff/109001/scm/tablature.scm#newcode297
scm/tablature.scm:297: (whiteout (ly:grob-property grob 'whiteout #t))
On 2010/11/28 22:24:05, Neil Puttock wrote:
> If 'whiteout is set, it's applied to the final stencil in grob.cc.


Removed it from the callback

http://codereview.appspot.com/2723043/diff/109001/scm/tablature.scm#newcode321
scm/tablature.scm:321: (centered-stencil output-grob)))
On 2010/11/28 22:24:05, Neil Puttock wrote:
> This has a nasty side-effect: it centres the noteheads on the
PaperColumn,
> shifting them to the left of heads in other staves.

Added an offset to get the column centered one character-width to the
right of the paper column.  I think it's even better than it used to be.

http://codereview.appspot.com/2723043/