Re: Change stringTunings entries from semitones to pitches (issue3842041)

[Carl . D . Sorensen]

On 2010/12/29 02:25:44, Keith wrote:
> I'm not a programmer, but accustomed to doing code review as a systems
engineer.


I very much appreciate the review.  Thanks!


> > Change stringTunings entries from semitones to pitches
> > This lays the foundation for creating a TabKey grob

> Presumably the idea is to store the correct spelling of the note in
the future
> TabKey, should anyone tune a string to des or cis.  Tell us if there
is a
> less-obvious reason.

That is exactly the reason.


> I *thought* that this would make \transpose, when applied to the whole
score,
> shift the tuning as well.  When I tried your patch, though, only the
music was
> transposed and not the tuning.  I think that is fine; I'm just
jiggling our
> brains looking for side-effects.

StringTunings is a characteristic of an instrument, not a characteristic
of music.  So I don't think that transpose should affect StringTunings.

I'll respond to your detailed comments in the body.

Thanks,

Carl


http://codereview.appspot.com/3842041/