Re: Change stringTunings entries from semitones to pitches (issue3842041)

[k-ohara5a5a]

Everything I know how to check looks good.


http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely#newcode477
Documentation/notation/fretted-strings.itely:477: A string tuning is a
Scheme list of string pitches,
> I'm fine to change the order, but I don't want to eliminate the
definition of a
> string tuning.
Sounds good.  Having the info about the Scheme representation closer to
the @file links down below would be great.

http://codereview.appspot.com/3842041/diff/6001/ly/string-tunings-init.ly
File ly/string-tunings-init.ly (right):

http://codereview.appspot.com/3842041/diff/6001/ly/string-tunings-init.ly#newcode28
ly/string-tunings-init.ly:28: (ly:parser-define! parser tuning-symbol
(reverse pitches))))
> The order in the internal storage is somewhat less than arbitrary.
Agreed. My earlier 'arbitrary' was a mental slip. I was thinking the
choice was sensible, but even if it were arbitrary I would be scared of
change.

> The order for the chord entry was requested by the users.  Chords are
generally
> entered lowest note first.

Yes, but were the users right?  I would have asked for that order of
entry, too, but would have changed my mind for fear of bugs when
reminded that the old way to specify tuning was in order of string
numbering.  (Bugs made by me in my .ly files, that is)
If you found this reversal not too error-prone, then maybe the users
were right.

http://codereview.appspot.com/3842041/diff/6001/ly/string-tunings-init.ly#newcode43
ly/string-tunings-init.ly:43: (make-music 'SequentialMusic 'void #t)))
> We need to save the string tuning in a Scheme variable...
But if it is possible to set the variable as you do now, and then return
a PropertySet instead of the void event,
(begin
  (chord->tuning parser tuning chord)
  (context-spec-music
    (make-property-set 'stringTunings tuning )
  'TabStaff)
)
then we could
\new TabStaff {
 \setStringTuning #'a-fiddle-tuning <g d' a' d''>

http://codereview.appspot.com/3842041/diff/6001/ly/string-tunings-init.ly#newcode96
ly/string-tunings-init.ly:96: ;; orchestral strings
On 2010/12/29 03:50:23, Carl wrote:
> On 2010/12/29 02:25:44, Keith wrote:
> > Why bother to add more default tunings?
> Because the users who requested this change asked for it.
Okay. I saw the request for an easier entry method but not for the
pre-define.

http://codereview.appspot.com/3842041/