|
| From: | percival . music . ca |
| Subject: | Re: Adds beam collision avoidance to auto beaming (issue4290069) |
| Date: | Sun, 27 Mar 2011 19:29:47 +0000 |
http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc#newcode55 lily/beam-collision-engraver.cc:55: if (covered_grobs_.size ()) I'm going to start testing this now, but it's sad to see: - an 8-level nested if/loop construct (!(?(!(?(!)?)!)?)!) - so many comments vanishing Hopefully somebody can suggest a refactoring which is easier to read? http://codereview.appspot.com/4290069/
| [Prev in Thread] | Current Thread | [Next in Thread] |