lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adds beam collision avoidance to auto beaming (issue4290069)


From: address@hidden
Subject: Re: Adds beam collision avoidance to auto beaming (issue4290069)
Date: Sun, 27 Mar 2011 16:23:53 -0400

On Mar 27, 2011, at 3:29 PM, address@hidden wrote:

> 
> http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc
> File lily/beam-collision-engraver.cc (right):
> 
> http://codereview.appspot.com/4290069/diff/5001/lily/beam-collision-engraver.cc#newcode55
> lily/beam-collision-engraver.cc:55: if (covered_grobs_.size ())
> I'm going to start testing this now, but it's sad to see:
> - an 8-level nested if/loop construct (!(?(!(?(!)?)!)?)!)

I only count 7!  But the indentation was off (fixed).

> - so many comments vanishing
> 

That's because most of the code vanished.  I can add a comment if you want - 
where would it benefit most from a comment (meaning where is it difficult to 
understand from variable names & from following the loops?)?

Cheers,
MS


reply via email to

[Prev in Thread] Current Thread [Next in Thread]