lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add support for custom ledger positions, using two new staff-symbol


From: k-ohara5a5a
Subject: Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)
Date: Mon, 17 Oct 2011 05:12:00 +0000

Piers, there are segfaults and infinite loops reported at
http://code.google.com/p/lilypond/issues/detail?id=1972


http://codereview.appspot.com/4974075/diff/21001/lily/staff-symbol.cc
File lily/staff-symbol.cc (right):

http://codereview.appspot.com/4974075/diff/21001/lily/staff-symbol.cc#newcode186
lily/staff-symbol.cc:186: SCM s = scm_cdr (ledger_positions);
if ledger-positions = '(1) we probably shouldn't enter the do loop; line
218 might segfault

http://codereview.appspot.com/4974075/diff/21001/lily/staff-symbol.cc#newcode192
lily/staff-symbol.cc:192: current = scm_to_double (s2) + n * cycle;
if ledger-positions are equal, 0.0==cycle, so current does not advance

http://codereview.appspot.com/4974075/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]