lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add support for custom ledger positions, using two new staff-symbol


From: k-ohara5a5a
Subject: Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)
Date: Tue, 25 Oct 2011 01:39:39 +0000

One obvious change to get it to compile, and then it looks good to me.

If you email me a patch from `git format-patch` I'll push it with you as
author; otherwise I'll just push it after countdown.


http://codereview.appspot.com/4974075/diff/33001/lily/staff-symbol.cc
File lily/staff-symbol.cc (right):

http://codereview.appspot.com/4974075/diff/33001/lily/staff-symbol.cc#newcode188
lily/staff-symbol.cc:188: if (!is_pair(s) || cycle < 0.1)
if (!scm_is_pair (s) || cycle < 0.1)

You can run  `scripts/auxiliar/fixcc.py foo.cc`
to put in the GNU-coding-style spaces.

http://codereview.appspot.com/4974075/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]