lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch series (available at branch dev/syntax) for more argument list


From: dak
Subject: Re: Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)
Date: Sat, 05 Nov 2011 06:36:41 +0000

On 2011/11/05 06:32:26, dak wrote:
On 2011/11/05 06:15:49, dak wrote:
> On 2011/11/04 23:43:04, Reinhold wrote:
> > On 2011/11/03 22:59:52, J_lowe wrote:
> > > Passes make and make check, No reg test diffs.
> >
> > Is Patch Set 3 the final version, or are the three patch sets
independent
> > patches that need to be applied one after the other??? It seems
that the
patch
> > set 3 does not contain many changes from the first two patch sets.
>
> Patch set 3 is just fixing an operator priority problem that caused
regtest
> failures with patch set 2.  Patch set 2 is a large reorg/addition on
top of
> patch set 1.
>
> Rietveld displays large deltas (without noticeable content)
presumably because
I
> rebased the branch on the new master.

I'll try removing the second patch set, and call the third one by its
old name.
This reflects the realities of the fixed patch series (available as
dev/syntax
branch) better.

Sigh.  Rietveld.  To rename the remaining patch set delta, I would
likely have to delete it and save it again.  But people may already be
reviewing it.  So it gets a misleading name.  Sorry for that.

http://codereview.appspot.com/5333051/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]