Re: Gets vertical skylines from grob stencils (issue 5626052)

[dak]

I actually only wanted to get rid of the whitespace errors plagueing
every test of this patch, but one programming error jumped out so badly
at me that I had to flag it as well.


http://codereview.appspot.com/5626052/diff/79059/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):

http://codereview.appspot.com/5626052/diff/79059/lily/axis-group-interface.cc#newcode726
lily/axis-group-interface.cc:726:
Whitespace in empty line.

http://codereview.appspot.com/5626052/diff/79059/lily/axis-group-interface.cc#newcode767
lily/axis-group-interface.cc:767:
Whitespace in empty line.

http://codereview.appspot.com/5626052/diff/79059/lily/axis-group-interface.cc#newcode798
lily/axis-group-interface.cc:798:
Whitespace in empty line.

http://codereview.appspot.com/5626052/diff/79059/lily/skyline.cc
File lily/skyline.cc (right):

http://codereview.appspot.com/5626052/diff/79059/lily/skyline.cc#newcode281
lily/skyline.cc:281: bool dirty = false;
Trailing whitespace at end of line, but actually the whole line seems
like it should be deleted, or otherwise the loop will always execute
exactly once since the variable `dirty' that is being set in the loop is
not the same as the variable `dirty' that is checked at its end.

http://codereview.appspot.com/5626052/diff/79059/lily/skyline.cc#newcode583
lily/skyline.cc:583:
Whitespace in empty line.

http://codereview.appspot.com/5626052/diff/79059/lily/skyline.cc#newcode710
lily/skyline.cc:710: end = i->start_;
Trailing whitespace.

http://codereview.appspot.com/5626052/diff/79059/lily/skyline.cc#newcode711
lily/skyline.cc:711: pad_buildings.push_back (Building (start, height,
height, end));
Trailing whitespace.

http://codereview.appspot.com/5626052/diff/79059/lily/skyline.cc#newcode728
lily/skyline.cc:728: pad_buildings.push_back (Building (start, height,
height - horizon_padding, end));
Trailing whitespace.

http://codereview.appspot.com/5626052/diff/79059/lily/skyline.cc#newcode834
lily/skyline.cc:834: return NOT_ENOUGH_INFO;
Trailing whitespace.

http://codereview.appspot.com/5626052/diff/79059/lily/system.cc
File lily/system.cc (right):

http://codereview.appspot.com/5626052/diff/79059/lily/system.cc#newcode426
lily/system.cc:426: return grobs_scm;
Trailing whitespace.

http://codereview.appspot.com/5626052/