|
From: | dak |
Subject: | Re: Fix Issue 2146 "Illegal entry in bfrange block in ToUnicode CMap" (issue 6399046) |
Date: | Sun, 15 Jul 2012 03:10:04 +0000 |
http://codereview.appspot.com/6399046/diff/1/configure.in File configure.in (right): http://codereview.appspot.com/6399046/diff/1/configure.in#newcode66 configure.in:66: _NCSB_SOURCE_FILES_="" On 2012/07/15 00:37:15, John Mandereau wrote:
On 2012/07/15 00:21:16, Graham Percival wrote: > what's the convention for leading _ in names? I havent' encountered
this
> before.
It was just my lack of imagination for a variable that should go
through
filtering (namely checking for "Cyrillic") before being AC_SUBSTed. If
using an
underscore is really not appropriate, then I'll invent some variable
name. Why does the underscore help here? The answer should likely be a code comment as well. http://codereview.appspot.com/6399046/
[Prev in Thread] | Current Thread | [Next in Thread] |