Re: Patchy switches for forcing make doc don't seem to work

[John Mandereau]

Il giorno lun, 20/08/2012 alle 15.53 +0100, James ha scritto:
> What might be more convenient - depending on the approach - is to be
> able to arbitrarily run ./test-patchy.py at a tracker issue regardless
> of patch status and build the doc based on it.

This was added in
commit cbd969135e8ec8c08fcccfe1ca96775c1c77ccac
Author: Julien Rioux <address@hidden>
Date:   Sat Feb 25 18:46:21 2012 +0100

    Allow to specify issue numbers on the command line for testing.
    
    If no issue number is provided, query for Patch=new issues, as usual.


This means you can already do something like

test-patches.py 2756 2761


> That means that I can run ./test-patchy.py normally and then once the
> basic tests are done I can run it again and *just* make doc.

No, because Patchy as it is in master branch now does "make clean" and
"git reset --hard", so you can't come into the process and do a "make
doc" in the middle, unless you start Patchy in Python debugger and stop
it at the right step, and then don't forget to do doc-clean for the next
issue, but I wouldn't play into doing this, nor recommend to do so.
Even in patchy/test-grenouille branch with the option to build docs, I
still need to make Patchy copy the docs tree in case the build succeeds,
and make doc-clean between issues, for this to work.


> At the moment I  use the patch command from a downloaded rietveld diff
> file; which works but means I have to manually make sure (and remember
> to check) that git is cleared out of any files that get created either
> with the new patch or during compilation as they will not be part of
> git's history.

This is already taken care of: Patchy only creates branches in
$LILYPOND_GIT, it doesn't check them out nor tries to applies patch; it
rather checks out the work tree and apply patches in a separate Git repo
cloned from $LILYPOND_GIT, and even in this clone, Patchy runs "make
clean" and "git reset --hard", so you don't have to worry about this.


>  I don't know how else to get a git formatted patch from
> a tracker/rietveld issue and apply it to my own tree to test without
> asking for it from the dev.

This is more cumbersome than it is hard (you need to "download raw patch
set", then save as from your browser, or copy-paste that link in a
terminal to download it with wget).  With Gerrit (a codereview system
more integrated with Git), it will be easier (just fetch the branch of
the issue).  Whatever.  We have this automatically with Patchy not only
to make it easier, but also to avoid manipulation errors which all
developers do from time to time.

Best,
John