lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Gets vertical skylines from grob stencils (issue 5626052)


From: joeneeman
Subject: Re: Gets vertical skylines from grob stencils (issue 5626052)
Date: Wed, 22 Aug 2012 03:43:03 +0000

On 2012/08/21 07:42:38, Keith wrote:
On 2012/08/18 10:12:00, MikeSol wrote:

> \relative c'' {
>    \override TupletBracket #'outside-staff-priority = #1
>    \override TupletNumber #'font-size = #5
>    \times 2/3 { a4\trill a\trill^"foo" a\trill }
> }
>
> I added this as a regtest.  If you comment out the rider business,
> you'll see that foo is printed on top of the tuplet number.

You gave TupletBracket a priority, but not TupletNumber.  Wouldn't it
make more
sense to have
   \override TupletNumber #'outside-staff-priority = #1
as well ?

If I strip out the special-case code
<http://codereview.appspot.com/6462087>
then all the Grobs honor the priorities I set for them.


Have you tried setting TupletNumber's priority to be smaller than
TupletBracket? It results TupletNumber moving twice as far as it should
(making it collide with "foo"), because first it translates itself and
then it gets moved again because TupletBracket moves, and its position
is measured relative to TupletBracket.

It would also be possible for some grob to insert itself between the
TupletBracket and the TupletNumber, which isn't particularly nice
either. So I think some form of "rider" functionality is necessary. I do
it a little differently in my branch, which even allows the TupletNumber
to affect the position of the TupletBracket.

Cheers,
Joe


http://codereview.appspot.com/5626052/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]