lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Standardizes use of empty extents in pure heights and skylines. (iss


From: Keith OHara
Subject: Re: Standardizes use of empty extents in pure heights and skylines. (issue 7310075)
Date: Sun, 10 Feb 2013 12:21:37 -0800
User-agent: Opera Mail/12.12 (Win32)

On Sat, 09 Feb 2013 23:24:41 -0800, <address@hidden> wrote:

https://codereview.appspot.com/7310075/diff/10/lily/grob.cc#newcode488
lily/grob.cc:488: Interval iv = robust_scm2interval (iv_scm, Interval
());
On 2013/02/10 03:08:04, Keith wrote:
I assume you will apply this change and the change in
separation-item.cc in a
separate commit, the "empty extents in pure-heights" part of the patch
set.

I'm not sure if these changes can be separated from the skyline stuff
without causing regtest havoc.

Oh, right.
If zero-horizon-dimension boxes are included in skylines they would be included 
in the skylines for note-spacing as well, so the default height should be 
empty, not zero, and a special kind of empty so that extra-spacing-height still 
applies.
OK

https://codereview.appspot.com/7310075/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]