lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Isolated durations in music sequences now stand for unpitched notes


From: dak
Subject: Re: Isolated durations in music sequences now stand for unpitched notes (issue 22120043)
Date: Sat, 09 Nov 2013 18:51:38 +0000


https://codereview.appspot.com/22120043/diff/40001/lily/parser.yy
File lily/parser.yy (right):

https://codereview.appspot.com/22120043/diff/40001/lily/parser.yy#newcode649
lily/parser.yy:649: | FRACTION
On 2013/11/09 17:12:52, Trevor Daniels wrote:
I don't like the mixed tabs and spaces here

There are no mixed tabs and spaces in the patch or its immediate
context.  A few lines later there is a spaces-only line, probably
introduced during a time where LilyPond globally configured spaces-only
mode for Emacs and this file did not yet contain a use-tabs override (as
the Bison file is indented in a tabs-style mode customary for such
files).

I don't think it is a good idea to reformat unrelated stuff in this
patch.

https://codereview.appspot.com/22120043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]