Re: python/convertrules.ly: Use bare rhythms after ties for simple cases (issue 49470049)

[dak]

Reviewers: Trevor Daniels,


https://codereview.appspot.com/49470049/diff/1/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):

https://codereview.appspot.com/49470049/diff/1/Documentation/learning/fundamental.itely#newcode1054
Documentation/learning/fundamental.itely:1054: r8 e4 d c8 ~ | 8 b16 a b8
g ~ 2 |
On 2014/01/10 17:35:11, Trevor Daniels wrote:
> Didn't we decide a while ago to attach ties
> to notes without an intervening space?  There
> are obviously lots more like this too.

Well, of course: this is a pattern.  Now the thing is that if you attach
ties to notes without an intervening space (or at least let them stand
if they were so before), we have possibilities

r8 e4 d c8~ | c8 b16 a b8 g~ g2 |
r8 e4 d c8~ | 8 b16 a b8 g~2 |

I am actually most worried about things like

r8 e4 d c8-.->~ | 8 c8 b16 a b8 g-.->~4~4 |

which I considered to read better as

r8 e4 d c8-.-> ~ | 8 c8 b16 a b8 g-.-> ~ 4 ~ 4 |

Obviously, the point of this full patch is to figure out where we want
the rules to go.  It's also conceivable to do a "space after ~ only if
there was one before" rule.

https://codereview.appspot.com/49470049/diff/1/Documentation/learning/templates.itely
File Documentation/learning/templates.itely (right):

https://codereview.appspot.com/49470049/diff/1/Documentation/learning/templates.itely#newcode62
Documentation/learning/templates.itely:62: BassMusic = \relative c' {
c2\p c4 c }
On 2014/01/10 17:35:11, Trevor Daniels wrote:
> This is wrong.  Why should we not use the
> new facility you introduced in 2.19 and
> let the first note specify the octave?

The question is rather why this file is marked "version 2.16.0".  Oh
wait, because this \relative conversion was _not_ applied to the
learning manual.  So yes, the upgrade from 2.16.0 _will_ require using
\relative c' here.  Which is correct.

It would seem that when you added the respective template lines, you
should have updated the version number of the file as well.

Now of course, in analogy to the last conversion, I should exempt the
learning manual from this automatic conversion.  But you still should
fix the version header to 2.18.0 or so, assuming that no other rules
applied.

Description:
python/convertrules.ly: Use bare rhythms after ties for simple cases

Obviously also:

Run scripts/auxiliar/update-with-convert-ly.sh

Please review this at https://codereview.appspot.com/49470049/

Affected files (+885, -852 lines):
  M Documentation/cs/learning/common-notation.itely
  M Documentation/cs/learning/fundamental.itely
  M Documentation/cs/learning/tweaks.itely
  M Documentation/de/essay/engraving.itely
  M Documentation/de/extending/programming-interface.itely
  M Documentation/de/learning/common-notation.itely
  M Documentation/de/learning/fundamental.itely
  M Documentation/de/learning/tweaks.itely
  M Documentation/de/notation/changing-defaults.itely
  M Documentation/de/notation/fretted-strings.itely
  M Documentation/de/notation/input.itely
  M Documentation/de/notation/percussion.itely
  M Documentation/de/notation/pitches.itely
  M Documentation/de/notation/rhythms.itely
  M Documentation/de/notation/simultaneous.itely
  M Documentation/de/notation/staff.itely
  M Documentation/de/notation/vocal.itely
  M Documentation/es/essay/engraving.itely
  M Documentation/es/extending/programming-interface.itely
  M Documentation/es/learning/common-notation.itely
  M Documentation/es/learning/fundamental.itely
  M Documentation/es/learning/tweaks.itely
  M Documentation/es/notation/changing-defaults.itely
  M Documentation/es/notation/fretted-strings.itely
  M Documentation/es/notation/input.itely
  M Documentation/es/notation/percussion.itely
  M Documentation/es/notation/pitches.itely
  M Documentation/es/notation/rhythms.itely
  M Documentation/es/notation/simultaneous.itely
  M Documentation/es/notation/staff.itely
  M Documentation/es/notation/vocal.itely
  M Documentation/essay/engraving.itely
  M Documentation/extending/programming-interface.itely
  M Documentation/fr/essay/engraving.itely
  M Documentation/fr/extending/programming-interface.itely
  M Documentation/fr/learning/common-notation.itely
  M Documentation/fr/learning/fundamental.itely
  M Documentation/fr/learning/tweaks.itely
  M Documentation/fr/notation/changing-defaults.itely
  M Documentation/fr/notation/fretted-strings.itely
  M Documentation/fr/notation/input.itely
  M Documentation/fr/notation/percussion.itely
  M Documentation/fr/notation/pitches.itely
  M Documentation/fr/notation/rhythms.itely
  M Documentation/fr/notation/simultaneous.itely
  M Documentation/fr/notation/staff.itely
  M Documentation/fr/notation/vocal.itely
  M Documentation/hu/learning/common-notation.itely
  M Documentation/hu/learning/fundamental.itely
  M Documentation/it/learning/common-notation.itely
  M Documentation/it/learning/fundamental.itely
  M Documentation/it/learning/tweaks.itely
  M Documentation/it/notation/pitches.itely
  M Documentation/it/notation/rhythms.itely
  M Documentation/it/notation/simultaneous.itely
  M Documentation/it/notation/staff.itely
  M Documentation/ja/learning/common-notation.itely
  M Documentation/ja/learning/fundamental.itely
  M Documentation/ja/learning/tweaks.itely
  M Documentation/ja/notation/changing-defaults.itely
  M Documentation/ja/notation/fretted-strings.itely
  M Documentation/ja/notation/input.itely
  M Documentation/ja/notation/percussion.itely
  M Documentation/ja/notation/pitches.itely
  M Documentation/ja/notation/rhythms.itely
  M Documentation/ja/notation/simultaneous.itely
  M Documentation/ja/notation/staff.itely
  M Documentation/ja/notation/vocal.itely
  M Documentation/learning/common-notation.itely
  M Documentation/learning/fundamental.itely
  M Documentation/learning/templates.itely
  M Documentation/learning/tweaks.itely
  M Documentation/ly-examples/aucun-snippet.ly
  M Documentation/ly-examples/bach-bwv610.ly
  M Documentation/ly-examples/cary.ly
  M Documentation/ly-examples/sesto.ily
  M Documentation/ly-examples/tab-example.ly
  M Documentation/nl/learning/common-notation.itely
  M Documentation/nl/learning/fundamental.itely
  M Documentation/nl/learning/tweaks.itely
  M Documentation/notation/changing-defaults.itely
  M Documentation/notation/fretted-strings.itely
  M Documentation/notation/input.itely
  M Documentation/notation/percussion.itely
  M Documentation/notation/pitches.itely
  M Documentation/notation/simultaneous.itely
  M Documentation/notation/staff.itely
  M Documentation/notation/vocal.itely
  M Documentation/snippets/broken-crescendo-hairpin.ly
  M Documentation/snippets/changing-midi-output-to-one-channel-per-voice.ly
  M Documentation/snippets/figured-bass-headword.ly
  M  
Documentation/snippets/hiding-accidentals-on-tied-notes-at-the-start-of-a-new-system.ly
  M Documentation/snippets/how-to-change-fret-diagram-position.ly
  M  
Documentation/snippets/making-an-object-invisible-with-the-transparent-property.ly
  M Documentation/snippets/new/broken-crescendo-hairpin.ly
  M  
Documentation/snippets/new/making-an-object-invisible-with-the-transparent-property.ly
  M Documentation/snippets/new/unfretted-headword.ly
  M Documentation/snippets/rhythms-headword.ly
  M Documentation/snippets/simultaneous-headword.ly
  M Documentation/snippets/single-staff-template-with-notes-and-chords.ly
  M Documentation/snippets/unfretted-headword.ly
  M  
Documentation/snippets/using-arpeggiobracket-to-make-divisi-more-visible.ly
  M Documentation/snippets/using-ties-with-arpeggios.ly
  M Documentation/snippets/vocal-headword.ly
  M input/regression/accidental-forced-tie.ly
  M input/regression/accidental-tie.ly
  M input/regression/beam-multiplicity-over-rests.ly
  M input/regression/completion-heads-tie.ly
  M input/regression/grace-slashed-no-slur.ly
  M input/regression/lyric-extender-no-heads.ly
  M input/regression/midi-lyric-barcheck.ly
  M input/regression/morgenlied.ly
  M input/regression/mozart-hrn3-allegro.ily
  M input/regression/mozart-hrn3-romanze.ily
  M input/regression/mozart-hrn3-rondo.ily
  M input/regression/part-combine-global.ly
  M input/regression/part-combine-solo.ly
  M input/regression/part-combine.ly
  M input/regression/property-nested-override.ly
  M input/regression/quote-tie.ly
  M input/regression/repeat-percent.ly
  M input/regression/script-tie-collision.ly
  M input/regression/slur-broken-trend.ly
  M input/regression/slur-scoring.ly
  M input/regression/staff-online-symbol-absence.ly
  M input/regression/stem-direction.ly
  M input/regression/tablature-chord-repetition-finger.ly
  M input/regression/tablature-chord-repetition.ly
  M input/regression/tablature-full-notation.ly
  M input/regression/tablature-tie-behaviour.ly
  M input/regression/tablature-tie-spanner.ly
  M input/regression/tag-multiple.ly
  M input/regression/tie-dash.ly
  M input/regression/tie-dot.ly
  M input/regression/tie-grace.ly
  M input/regression/tie-single-manual.ly
  M input/regression/tie-single.ly
  M input/regression/tie-unterminated.ly
  M input/regression/typography-demo.ly
  M python/convertrules.py