lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: add stencil-whiteout-outline function (issue 236480043 by address@hi


From: paulwmorris
Subject: Re: add stencil-whiteout-outline function (issue 236480043 by address@hidden)
Date: Tue, 02 Jun 2015 01:44:17 +0000


https://codereview.appspot.com/236480043/diff/40001/python/convertrules.py
File python/convertrules.py (right):

https://codereview.appspot.com/236480043/diff/40001/python/convertrules.py#newcode3751
python/convertrules.py:3751: str = re.sub (r'\bwhiteout\b',
'whiteout-box', str)
On 2015/06/01 23:10:20, dak wrote:
That seems like a rather overenthusiastic conversion pattern.

Ah yes, good point.

Did you actually
try running
scripts/auxiliar/update-with-convert-ly.sh
with this?

Um... well, no...  I got in a hurry and didn't follow the CG thoroughly
enough.  Let me give it another try.

(I had actually already edited all occurrences manually (except for
snippets), and so wasn't thinking about convert-ly being run on the
documentation.  I now see the recommended way is to start with
convert-ly and then follow up with any needed manual edits.)

I suppose the most robust approach would be to have more than one rule
to match:

  "\whiteout" for the markup command
  ".whiteout" for grob property overrides
  "#'whiteout" for the older property syntax
  "stencil-whiteout" for the scheme function.

https://codereview.appspot.com/236480043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]